pedmf boundary conditions #4106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajjadazimi
force-pushed
the
sa/consistent_edmf_bcs
branch
5 times, most recently
from
19ec0c3 to
11d17bb
Compare
sajjadazimi
force-pushed
the
sa/consistent_edmf_bcs
branch
from
d2f7de0 to
ded9fa3
Compare
tapios
approved these changes
Nov 25, 2025
Member
tapios
left a comment
tapios
left a comment
There was a problem hiding this comment.
LGTM. It'll be good to see how well this work across a range of SCM simulations. This PR looks conceptually and code-wise fine to me.
sajjadazimi
force-pushed
the
sa/consistent_edmf_bcs
branch
from
8ed26d2 to
e39b09b
Compare
szy21
reviewed
Nov 26, 2025
szy21
reviewed
Nov 26, 2025
sajjadazimi
force-pushed
the
sa/consistent_edmf_bcs
branch
from
81719ea to
e1f8497
Compare
…ainment of buoyant fluid in the first cell
sajjadazimi
force-pushed
the
sa/consistent_edmf_bcs
branch
from
e1f8497 to
8fcc7b8
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
pedmf boundary conditions
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the treatment of boundary conditions for prognostic EDMF:
1- Apply surface fluxes to both grid-mean and updraft fields equally.
2- Seed a small updraft area fraction in the first cell when the surface buoyancy flux is positive, allowing it to grow even if initially zero.
3- Instead of overwriting the first-cell area fraction, increase the entrainment rate when buoyancy flux is positive, ensuring the area reaches the prescribed value in one timestep. This ensures that tracer masses are conserved.
4- Instead of overwriting mse and q_tot, assume a near-surface entrainment in the first cell, with tracer values of the entraining fluid provided by the function
sgs_scalar_first_interior_bc(mean + perturbation).Content